On 08/01/2025 3:45 pm, Alejandro Vallejo wrote:
> Hi,
>
> On Wed Jan 8, 2025 at 3:23 PM GMT, Stewart Hildebrand wrote:
>> It appears the variable ffa_fw_version is only used in ffa.c. Was there
>> any rationale for exporting the symbol in 2f9f240a5e87 ("xen/arm: ffa:
>> Fine granular call support")? If not, perhaps we ought to make it static
>> again and remove the declaration in the header.
> The only reason I can think of is wanting to have it in the symbol table of
> the
> ELF file for some reason (livepatching?)
Livepatching can work with static symbols just fine.
Binary diffing is per TU, looking at all symbols in the object, not just
global symbols.
~Andrew
