On 08/01/2025 07:51, Bertrand Marquis wrote:
Hi Ayan,
Hi Bertrand,
I just need clarifications on the two points and then I can send v4.
< snip>
+Domain Creation And Runtime
+===========================
+
+Kernel command line arguments
+-----------------------------
+
+`XenProd~kernel_cmd_line_args~1`
+
+Description:
+Xen shall pass kernel command line arguments to a domain via a device tree.
Would it make sense to say where the "command line" to pass is specified ?
Yes, although I don't feel very strongly about it. Let me know if this
sounds ok :-
Xen shall pass kernel command line arguments to a domain via a device tree
using the property "/chosen/xen,xen-bootargs".
< snip>
+
+vCPUs
+-----
+
+`XenProd~vcpus~1`
+
+Description:
+A domain shall have a configurable number of virtual CPUs (1 to XX).
XX should be replaced with "the maximum number specified at compilation
in the configuration through CONFIG_MAX_CPUS" or something like that.
Actually we are talking about virtual CPUS whereas CONFIG_MAX_CPUS refer
to physical cpus.
So, it should be GUEST_MAX_VCPUS (which is hardcoded to 128 in
xen/include/public/arch-arm.h).
Thus, s/XX/128
I agree with your other comments.
- Ayan
