On 30.12.2024 22:00, Maximilian Engelhardt wrote: > The objdump output is fed to grep, so make sure it doesn't change with > different user locales and break the grep parsing. > This problem was identified while updating xen in Debian and the fix is > needed for generating reproducible builds in varying environments.
It required me to check objdump (really: libbfd) source code to figure that it's ... > --- a/xen/arch/x86/arch.mk > +++ b/xen/arch/x86/arch.mk > @@ -109,7 +109,7 @@ endif > ifeq ($(XEN_BUILD_PE),y) > > # Check if the linker produces fixups in PE by default > -efi-nr-fixups := $(shell $(OBJDUMP) -p $(efi-check).efi | grep > '^[[:blank:]]*reloc[[:blank:]]*[0-9][[:blank:]].*DIR64$$' | wc -l) > +efi-nr-fixups := $(shell LC_ALL=C $(OBJDUMP) -p $(efi-check).efi | grep > '^[[:blank:]]*reloc[[:blank:]]*[0-9][[:blank:]].*DIR64$$' | wc -l) ... the "reloc" in here which (oddly enough) may be subject to translation. Would have been nice if such a relevant detail had been added to the description. Jan
