On Tuesday, December 10th, 2024 at 5:26 AM, Jan Beulich <jbeul...@suse.com> wrote:
> > > On 06.12.2024 05:41, Denis Mukhin via B4 Relay wrote: > > > --- a/xen/arch/x86/include/asm/domain.h > > +++ b/xen/arch/x86/include/asm/domain.h > > @@ -506,6 +506,9 @@ struct arch_domain > > #define has_pirq(d) (!!((d)->arch.emulation_flags & X86_EMU_USE_PIRQ)) > > #define has_vpci(d) (!!((d)->arch.emulation_flags & X86_EMU_VPCI)) > > > > +/* NB: same symbol as in Arm port */ > > +#define domain_has_vuart(d) false > > > This being the 3rd effectively identical patch, perhaps instead we want > to default domain_has_vuart() to false unless an arch provides its own > definition? Much like we do for a few other such items? Ideally, domain_has_vuart() should depend on build flags and d->arch.emulation_flags only. I have reworked the code, so that domain_has_vuart() is defined for all architectures uniformly. To do that, I plumbed d->arch.emulation_flags to all arch domain structures and made arch-independent emulation flags declarations in v3. > > Jan
