On 04/07/18 09:21, Jan Beulich wrote: >>>> On 03.07.18 at 22:55, <andrew.coop...@citrix.com> wrote: >> --- a/tools/include/Makefile >> +++ b/tools/include/Makefile >> @@ -21,6 +21,9 @@ xen/.dir: >> ln -sf $(addprefix $(XEN_ROOT)/xen/include/xen/,libelf.h elfstructs.h) >> xen/libelf/ >> ln -s ../xen-foreign xen/foreign >> ln -sf $(XEN_ROOT)/xen/include/acpi acpi >> +ifeq ($(CONFIG_X86),y) >> + ln -sf $(XEN_ROOT)/xen/include/xen/libx86 xen/libx86 >> +endif > Why not set the include path suitably?
Because this is how everything else is currently done. If we want to change how tools get their hypervisor header files, that should be independent work. > And otherwise, what harm would there be installing the link also when > targeting ARM? I'm fairly sure the ARM folk would object to having libx86 linked into their tools. ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel