On 17/12/2024 10:24 pm, Jason Andryuk wrote: > This patch is similar to the xenstore late init (though the flag is > reversed).
xenstore late init is fundamentally broken. Do not copy it. c/s fc2b57c9af462d67df871b080c0897156a616b7d broke the the ABI of that bit by trying to repurpose it for an incompatible use. Despite the claims, it is not possible for a 3rd to be involved in any way in the xenstore page. This lead to some nasty state corruption issues in the ring, which were simply papered over by repositioning the middle hunk, and not fixed. It causes cxenstored to have an incompatible ABI divergence of an oxenstored feature. The only reason I haven't reverted it is because it is my understanding that Hyperlauch is going to need to revert it anyway. The very first thing you need is a precise description of the semantics of this bit, including how it is used by the client and the server. I'll be dammed if I let a second spectacular breakage of a public interface occur due to inadequate planning; one is bad enough. ~Andrew
