Roger Pau Monne writes ("[PATCH 2/3] osstest: set the make command to use for xen-build"): > The default make on FreeBSD is the BSD make, and Xen requires the GNU > make in order to build. Set the make command based on the OS for the > Xen build. ... > our $dokconfig = 1; > +our $make = $ho->{OS} eq "freebsd" ? "gmake" : "make";
Wouldn't it be better to write $ho->{OS} =~ m/bsd/ or something ? Subject to either changing that, or having an answer: Acked-by: Ian Jackson <ian.jack...@eu.citrix.com> Thanks, Ian. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel