On 23.11.2024 19:20, Daniel P. Smith wrote:
> @@ -160,6 +161,42 @@ static int __init process_domain_node(
> else
> printk("PV\n");
> }
> + if ( match_fdt_property(fdt, prop, "memory" ) )
> + {
> + uint64_t kb;
> + if ( fdt_prop_as_u64(prop, &kb) != 0 )
> + {
> + printk(" failed processing memory for domain %s\n",
> + name == NULL ? "unknown" : name);
> + return -EINVAL;
> + }
> + bd->mem_pages = PFN_DOWN(kb * SZ_1K);
> + printk(" memory: %ld\n", bd->mem_pages << PAGE_SHIFT);
> + }
> + if ( match_fdt_property(fdt, prop, "mem-min" ) )
> + {
> + uint64_t kb;
> + if ( fdt_prop_as_u64(prop, &kb) != 0 )
> + {
> + printk(" failed processing memory for domain %s\n",
> + name == NULL ? "unknown" : name);
> + return -EINVAL;
> + }
> + bd->min_pages = PFN_DOWN(kb * SZ_1K);
> + printk(" min memory: %ld\n", bd->min_pages << PAGE_SHIFT);
> + }
> + if ( match_fdt_property(fdt, prop, "mem-max" ) )
> + {
> + uint64_t kb;
> + if ( fdt_prop_as_u64(prop, &kb) != 0 )
> + {
> + printk(" failed processing memory for domain %s\n",
> + name == NULL ? "unknown" : name);
> + return -EINVAL;
> + }
> + bd->max_pages = PFN_DOWN(kb * SZ_1K);
> + printk(" max memory: %ld\n", bd->max_pages << PAGE_SHIFT);
> + }
Since the values logged are all multiples of 1k, why make reading the logs
more complicated by logging byte-granular values? I instead wonder whether
converting to more coarse grained values (leaving, say, between 4 and 6
significant digits while using kb, Mb, Gb, etc) wouldn't be yet better.
Jan
