On 23.11.2024 19:20, Daniel P. Smith wrote: > To begin moving toward allowing the hypervisor to construct more than one > domain at boot, a container is needed for a domain's build information. > Introduce a new header, <xen/asm/bootdomain.h>, that contains the initial > struct boot_domain that encapsulate the build information for a domain.
Why does this need to be a per-arch header? Wasn't one of the goals to unify things as much as possible? > --- a/xen/arch/x86/include/asm/dom0_build.h > +++ b/xen/arch/x86/include/asm/dom0_build.h > @@ -13,9 +13,9 @@ unsigned long dom0_compute_nr_pages(struct domain *d, > unsigned long initrd_len); > int dom0_setup_permissions(struct domain *d); > > -struct boot_info; > -int dom0_construct_pv(struct boot_info *bi, struct domain *d); > -int dom0_construct_pvh(struct boot_info *bi, struct domain *d); > +struct boot_domain; > +int dom0_construct_pv(struct boot_domain *bd); > +int dom0_construct_pvh(struct boot_domain *bd); I'm wondering: Just a few commits ago you moved these to boot_info. Now you move them to boot_domain. Why the extra churn, and what further transformations are to be expected? Jan
