On 25.11.2024 18:52, Jason Andryuk wrote: > On 2024-11-23 13:20, Daniel P. Smith wrote: >> --- /dev/null >> +++ b/xen/arch/x86/domain_builder/fdt.c >> @@ -0,0 +1,38 @@ >> +/* SPDX-License-Identifier: GPL-2.0-only */ >> +/* >> + * Copyright (C) 2024, Apertus Solutions, LLC >> + */ >> +#include <xen/err.h> >> +#include <xen/init.h> >> +#include <xen/lib.h> >> +#include <xen/libfdt/libfdt.h> >> +#include <xen/rangeset.h> /* required for asm/setup.h */ > > Should asm/setup.h just be changed?
Why would it need changing (and why's that #include needed)? It has a proper forward decl of the struct tag, and I can't see why it would need anything else. Jan
