On 21.10.2024 17:45, Alejandro Vallejo wrote: > Refactors libacpi so that a single LUT is the authoritative source of > truth for the CPU to APIC ID mappings. This has a know-on effect in > reducing complexity on future patches, as the same LUT can be used for > configuring the APICs and configuring the ACPI tables for PVH. > > Not functional change intended, because the same mappings are preserved. > > Signed-off-by: Alejandro Vallejo <alejandro.vall...@cloud.com> > --- > v7: > * NOTE: didn't add assert to libacpi as initially accepted in order to > protect libvirt from an assert failure.
If such an assertion can trigger, doesn't that suggest a problem with the corresponding caller? I.e. isn't omitting the assertion merely trading a noisy failure for a silent (and possibly hard to understand) one? Jan
