On 20.11.2024 10:01, Roger Pau Monné wrote: > Secondly, the call to "PCI add device" is too late. It works now > because Xen scans for PCI devices, so those are already known and > setup by Xen. But if it's a hotplug device (or a device that somehow > is not discovered by Xen at boot), doing the PHYSDEVOP_pci_device_add > hypercall after sizing the device is wrong, the hypercall should be > done ahead of Linux interacting with the device in any meaningful way. > The checks done for device discovery are fine are obviously fine to be > done ahead of the PHYSDEVOP_pci_device_add call.
Let's make the Linux maintainers more explicitly aware of this. Jan
