> -----Original Message-----
> From: Jan Beulich [mailto:jbeul...@suse.com]
> Sent: Tuesday, July 3, 2018 3:12 PM
> To: Xin Li <talons....@gmail.com>
> Cc: Andrew Cooper <andrew.coop...@citrix.com>; Ming Lu
> <ming...@citrix.com>; Sergey Dyasli <sergey.dya...@citrix.com>; Wei Liu
> <wei.l...@citrix.com>; Xin Li (Talons) <xin...@citrix.com>; George Dunlap
> <george.dun...@citrix.com>; Stefano Stabellini <sstabell...@kernel.org>; xen-
> de...@lists.xen.org; Konrad Rzeszutek Wilk <konrad.w...@oracle.com>; Daniel
> de Graaf <dgde...@tycho.nsa.gov>; Tim (Xen.org) <t...@xen.org>
> Subject: Re: [PATCH 1/2] xen/xsm: Introduce new boot parameter xsm
>
> First of all - please indicate the version also in the subject, i.e. here
> [PATCH v2
> 1/2] or some such.
>
> >>> On 03.07.18 at 03:26, <talons....@gmail.com> wrote:
> > v2
> > To further discuss:
> > 1) is "dummy" a good command line option?
> > other choices: basic", "trivial", or "simple"
>
> Indeed, but not limited to the named set.
>
> Additionally, please have a brief summary of changes from the prior version
> here.
>
> > + switch ( xsm_bootparam )
> > + {
> > + case XSM_BOOTPARAM_DUMMY:
> > + break;
> > +
> > + case XSM_BOOTPARAM_FLASK:
> > + flask_init(policy_buffer, policy_size);
> > + break;
> > +
> > + default:
> > + printk("XSM: Invalid value for xsm= boot parameter.\n");
>
> As I think I've said before - generally no full stop at the end of log
> messages
> please. I also think that in error messages like this the offending string
> should
> be logged as well. Which points out an issue with the change: Without
> CONFIG_XSM_FLASK (under the current naming as proposed by Andrew; you
> should btw continue to name the dependency of your series on his one until
> that prereq has landed in staging, which you'd ideally do in a 0/2 cover
> letter) would perhaps better result in this error message to be issued, in
> favor
> of or in addition to the command line parsing one.
OK.
Remove this ".",
And in parse_xsm_param, add:
else {
printk("XSM: can't parse boot parameter xsm=%s\n", s);
rc = -EINVAL;
}
>
> Jan
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
