Hi Julien, > On 17 Nov 2024, at 17:46, Julien Grall <jul...@xen.org> wrote: > > Hi Luca, > > On 15/11/2024 10:50, Luca Fancellu wrote: >> Move some extern declarations related to MMU structures and define >> from asm/setup.h to asm/mm.h, in order to increase encapsulation and > > You are moving them to asm/mmu/mm.h. But I think I would prefer if they are > moved to asm/mmu/setup.h because boot_* are not supposed to be used outside > of boot. So it is clearer if they are still defined in a setup.h.
Sure I’ll move them to arm/mmu/setup.h >> >> - >> /* Find where Xen will be residing at runtime and return a PT entry */ >> lpae_t pte_of_xenaddr(vaddr_t va); > > Shouldn't we move this function as well? This one was not problematic, but I can move this one as well. Cheers, Luca
