On 14/11/2024 4:15 pm, Jan Beulich wrote: > On 14.11.2024 16:59, Andrew Cooper wrote: >> On 14/11/2024 11:11 am, Jan Beulich wrote: >>> On 12.11.2024 22:19, Andrew Cooper wrote: >>>> With the tangle of logic starting to come under control, it is now plain to >>>> see that parse_blob()'s side effect of re-gathering the signature/revision >>>> is >>>> pointless. >>>> >>>> The cpu_request_microcode() hooks need the signature only. The BSP gathers >>>> this in early_microcode_init(), the APs and S3 in microcode_update_cpu(). >>> That's microcode_update_one() after 502478bc1d9d if I'm not mistaken. >> I wouldn't necessarily say "after". > My point was merely that there's no microcode_update_cpu() anymore, as of > that commit.
Oh. I totally missed that. I'll fix it, and make the rest of the paragraph a little bit more direct. ~Andrew
