On 13.11.2024 10:38, Alessandro Zucchelli wrote: > This addresses violations of MISRA C:2012 Rule 5.4 which states as > following: Macro identifiers shall be distinct. > > This deviation aims to address violations of Rule 5.4 regarding > identifiers XLAT_hvm_altp2m_set_mem_access_multi_HNDL_pfn_list and > XLAT_hvm_altp2m_set_mem_access_multi_HNDL_access_list, and identifiers > declared in header file include/asm/guest/hyperv-tlfs.h.
Please can you provide enough context? The two identifiers are quite obviously distinct. Just not in the first 40 characters. A limit I had to actually go look up, because it's entirely arbitrary. Plus - what are we going to do if further such identifiers appear? Exclude them one by one? That wouldn't really scale. Can we perhaps make a wider exception, e.g. at least for all XLAT_*_HDNL_* ones? Then again part of the problem here is that hvm_altp2m_set_mem_access_multi is already excessively long, alone taking up 31 characters. Jan
