On 13.11.2024 09:17, Federico Serafini wrote: > Make explicit the fallthrough intention by adding the pseudo keyword > where missing and replace fallthrough comments not following the > agreed syntax. > > This satisfies the requirements to deviate violations of > MISRA C:2012 Rule 16.3 "An unconditional break statement shall > terminate every switch-clause". > > No functional change. > > Signed-off-by: Federico Serafini <federico.seraf...@bugseng.com>
Repeating my v1 comment: "We can certainly take this as is, as a tiny first step. Personally I'm not overly happy though to see a mix of comment- and pseudo-keyword- style annotations in individual files. After all going forward we'll want to use the latter, now that this becomes possible. Yet for that I view it a more than just helpful if bad precedents didn't exist anymore. Being the one to touch the emulator files most, I can say that here more than perhaps anywhere else new code is very often added by copy-and-paste-then-edit. Therefore question in particular to the other x86 maintainers: Won't we be better off if we fully convert to pseudo-keyword-style right away?" I'm afraid I don't like this "don't care" behavior, yet once again in the interest of making progress: Acked-by: Jan Beulich <jbeul...@suse.com> Jan
