On 07.11.2024 16:55, Roger Pau Monné wrote: > On Thu, Nov 07, 2024 at 04:20:35PM +0100, Jan Beulich wrote: >> On 07.11.2024 16:15, Roger Pau Monne wrote: >>> The size of the alt_instr structure in Xen is 14 instead of 12 bytes, adjust >>> it. >> >> Nowadays yes. Isn't the tool supposed to be usable with all livepatch-capable >> Xen versions, though? As a random data point, 4.7 still had the size at 12. > > Yes, livepatch-build-tools will fetch the alt_intsrt size from the > DWARF info. > > However when using create-diff-object without the env variable being > set a default value is used, and that's currently 12. I think it > would be best to update that default to the value used by the current > Xen version.
Oh, I see. Makes sense of course. Jan
