On 30.10.2024 10:50, oleksii.kuroc...@gmail.com wrote:
> On Tue, 2024-10-29 at 17:57 +0100, Jan Beulich wrote:
>> On 29.10.2024 17:47, Oleksii Kurochko wrote:
>>> --- a/xen/common/device.c
>>> +++ b/xen/common/device.c
>>> @@ -4,10 +4,14 @@
>>> * xen/arch/arm/device.c
>>> */
>>>
>>> +#include <xen/acpi.h>
>>> #include <xen/bug.h>
>>> #include <xen/device_tree.h>
>>> #include <xen/errno.h>
>>> #include <xen/init.h>
>>> +#include <xen/kernel.h>
>>> +#include <xen/lib.h>
>>> +#include <xen/types.h>
>>
>> I don't think non-ACPI configs should include xen/acpi.h here. Surely
>> this
>> can be moved down into the ACPI-only code section?
> xen/acpi.h was included as acpi_disabled is defined there and it is
> needed in commom/device.c for:
> ```
> void __init ic_preinit(void)
> {
> if ( acpi_disabled )
> ic_dt_preinit();
> else
> ic_acpi_preinit();
> }
> ```
Oh, I see.
Jan
