On Thu, Oct 24, 2024 at 11:51:16AM +0000, Anthony PERARD wrote: > On Thu, Oct 24, 2024 at 11:04:19AM +0100, Javi Merino wrote: > > diff --git a/automation/build/debian/12-arm64v8-arm32-gcc.dockerfile > > b/automation/build/debian/12-arm64v8-arm32-gcc.dockerfile > > new file mode 100644 > > index 000000000000..bdc935706bfa > > --- /dev/null > > +++ b/automation/build/debian/12-arm64v8-arm32-gcc.dockerfile > > @@ -0,0 +1,28 @@ > > +# syntax=docker/dockerfile:1 > > +FROM --platform=linux/arm64/v8 debian:bookworm > > +LABEL maintainer.name="The Xen Project" \ > > + maintainer.email="xen-devel@lists.xenproject.org" > > Recent update of other dockerfile was repeating the "LABEL" intruction > for each label, maybe we should continue to do that (which avoid the > backslash at the end of lines).
Sure. I will do that if there's a v2 (or for other dockerfiles). > > +ENV DEBIAN_FRONTEND=noninteractive > > +ENV CROSS_COMPILE /usr/bin/arm-linux-gnueabihf- > > While the syntax "ENV VAR value" is supported, it's been discouraged by > docker's doc (https://docs.docker.com/reference/dockerfile/#env). Also, > here we have two ENV instructions with two different syntax, could you > use the = for declaring CROSS_COMPILE as well? I hadn't even noticed that they were using different syntax. I'll use ENV VAR=value from now on. Thanks, Javi
