On 22/10/2024 12:46 pm, Roger Pau Monne wrote: > BUG_ON() itself already contains an unlikely() wrapping the bug condition. > > No functional change. > > Signed-off-by: Roger Pau Monné <roger....@citrix.com>
Acked-by: Andrew Cooper <andrew.coop...@citrix.com> likely()/unlikely() annotations are notoriously difficult for humans to reason about, and I think we have many wrong examples in Xen. In some copious free time, I was thinking of borrowing Linux's ftrace mechanism for identifying broken annotations. All it involves is turning if() into a macro...
