On 10/7/24 14:29, Jason Andryuk wrote:
On 2024-10-06 17:49, Daniel P. Smith wrote:
This will introduce a new struct boot_module to provide a rich state
representation around modules provided by the boot loader. Support is
for 64
boot modules, one held in reserve for Xen, and up to 63 can be
provided by the
boot loader. The array of struct boot_modules will be accessible via a
reference held in struct boot_info.
A temporary `mod` parameter is included in struct boot_module to ease the
transition from using Multiboot v1 structures over to struct
boot_module. Once
the transition is complete, the parameter will be dropped from the
structure.
Signed-off-by: Daniel P. Smith <dpsm...@apertussolutions.com>
---
xen/arch/x86/include/asm/bootinfo.h | 14 ++++++++++++--
xen/arch/x86/setup.c | 9 +++++++++
2 files changed, 21 insertions(+), 2 deletions(-)
diff --git a/xen/arch/x86/include/asm/bootinfo.h
b/xen/arch/x86/include/asm/bootinfo.h
index 87d311ac1399..d19473d8941e 100644
--- a/xen/arch/x86/include/asm/bootinfo.h
+++ b/xen/arch/x86/include/asm/bootinfo.h
@@ -8,20 +8,30 @@
#ifndef __XEN_X86_BOOTINFO_H__
#define __XEN_X86_BOOTINFO_H__
+#include <xen/multiboot.h>
#include <xen/types.h>
+/* Max number of boot modules a bootloader can provide in addition to
Xen */
+#define MAX_NR_BOOTMODS 63
+
+struct boot_module {
+ /* Transitionary only */
+ module_t *mod;
+};
+
/*
* Xen internal representation of information provided by the
* bootloader/environment, or derived from the information.
*/
struct boot_info {
- unsigned int nr_modules;
-
(You should probably re-work the other patches to insert ahead of this
and avoid the movement.)
Ack.
const char *loader;
const char *cmdline;
paddr_t memmap_addr;
size_t memmap_length;
+
+ unsigned int nr_modules;
+ struct boot_module mods[MAX_NR_BOOTMODS + 1];
};
Reviewed-by: Jason Andryuk <jason.andr...@amd.com>
Thank you.
v/r,
dps