On 07.10.2024 20:09, Jason Andryuk wrote:
> On 2024-10-06 17:49, Daniel P. Smith wrote:
>> Transition Xen's command line to being held in struct boot_info.
>>
>> No functional change intended.
>>
>> Signed-off-by: Daniel P. Smith <dpsm...@apertussolutions.com>
>> Acked-by: Andrew Cooper <andrew.coop...@citrix.com>
>> ---
> 
>>   #endif /* __XEN_X86_BOOTINFO_H__ */
>> diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c
>> index aafc098ca268..0921f296075f 100644
>> --- a/xen/arch/x86/setup.c
>> +++ b/xen/arch/x86/setup.c
>> @@ -274,6 +274,8 @@ static int __init cf_check parse_acpi_param(const char 
>> *s)
>>   }
>>   custom_param("acpi", parse_acpi_param);
>>   
>> +static const char *cmdline_cook(const char *p, const char *loader_name);
> 
> Is there a reason not to move cmdline_cook() (and loader_is_grub2()) 
> earlier to avoid this forward declaration?

At a guess: To limit churn?

Jan

Reply via email to