On Wed, Jun 20, 2018 at 04:42:27PM +0200, Roger Pau Monne wrote: > Tear down functions are not mandatory. Note that this patch just > implements the framework, but doesn't implement any tear down function > yet. > > No functional change intended. > > Signed-off-by: Roger Pau Monné <roger....@citrix.com> > --- > Cc: Andrew Cooper <andrew.coop...@citrix.com> > Cc: George Dunlap <george.dun...@eu.citrix.com> > Cc: Ian Jackson <ian.jack...@eu.citrix.com> > Cc: Jan Beulich <jbeul...@suse.com> > Cc: Julien Grall <julien.gr...@arm.com> > Cc: Konrad Rzeszutek Wilk <konrad.w...@oracle.com> > Cc: Stefano Stabellini <sstabell...@kernel.org> > Cc: Tim Deegan <t...@xen.org> > Cc: Wei Liu <wei.l...@citrix.com> > --- > xen/arch/arm/xen.lds.S | 9 +-------- > xen/arch/x86/xen.lds.S | 9 +-------- > xen/drivers/vpci/header.c | 2 +- > xen/drivers/vpci/msi.c | 2 +- > xen/drivers/vpci/msix.c | 2 +- > xen/drivers/vpci/vpci.c | 20 +++++++++++++++++--- > xen/include/xen/vpci.h | 15 +++++++++++---- > 7 files changed, 33 insertions(+), 26 deletions(-) > > diff --git a/xen/arch/arm/xen.lds.S b/xen/arch/arm/xen.lds.S > index 245a0e0e85..2c6a09c59d 100644 > --- a/xen/arch/arm/xen.lds.S > +++ b/xen/arch/arm/xen.lds.S > @@ -66,7 +66,7 @@ SECTIONS > *(.data.param) > __param_end = .; > > -#if defined(CONFIG_HAS_VPCI) && defined(CONFIG_LATE_HWDOM) > +#if defined(CONFIG_HAS_VPCI) > . = ALIGN(POINTER_ALIGN); > __start_vpci_array = .; > *(SORT(.data.vpci.*)) > @@ -178,13 +178,6 @@ SECTIONS > *(.init_array) > *(SORT(.init_array.*)) > __ctors_end = .; > - > -#if defined(CONFIG_HAS_VPCI) && !defined(CONFIG_LATE_HWDOM) > - . = ALIGN(POINTER_ALIGN); > - __start_vpci_array = .; > - *(SORT(.data.vpci.*)) > - __end_vpci_array = .; > -#endif
It is worth mentioning in the commit message that why this is deleted. I think it is because now they should be unconditionally put into rodata since they can't be discarded after boot anymore. The code looks OK. Wei. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
