On 26/09/2024 11:14 am, Roger Pau Monne wrote:
> diff --git a/xen/arch/x86/alternative.c b/xen/arch/x86/alternative.c
> index 7824053c9d33..990b7c600932 100644
> --- a/xen/arch/x86/alternative.c
> +++ b/xen/arch/x86/alternative.c
> @@ -198,9 +198,29 @@ static void init_or_livepatch _apply_alternatives(struct
> alt_instr *start,
> uint8_t buf[MAX_PATCH_LEN];
> unsigned int total_len = a->orig_len + a->pad_len;
>
> - BUG_ON(a->repl_len > total_len);
> - BUG_ON(total_len > sizeof(buf));
> - BUG_ON(a->cpuid >= NCAPINTS * 32);
> + if ( a->repl_len > total_len )
> + {
> + printk(XENLOG_ERR
> + "alt for %ps, replacement size %#x larger than origin
> %#x\n",
"Alt" I think. It's both an abbreviation, and the start of the sentence
here.
Can fix on commit.
Reviewed-by: Andrew Cooper <[email protected]>
