On 17.09.2024 18:15, Oleksii Kurochko wrote: > --- a/xen/common/Kconfig > +++ b/xen/common/Kconfig > @@ -12,6 +12,14 @@ config CORE_PARKING > bool > depends on NR_CPUS > 1 > > +config DEVICE_INIT > + bool > + default !X86
This can simply be "def_bool y" as ... > + depends on !X86 && (ACPI || HAS_DEVICE_TREE) ... this enforces all restrictions. As indicated before I'd prefer if we could get away without yet another Kconfig constant, which would then also eliminate my concern about the expression not really covering for the case where x86 would obtain DT support (and hence likely needing the initialization here, too). What about ... > --- a/xen/common/Makefile > +++ b/xen/common/Makefile > @@ -6,6 +6,7 @@ obj-$(CONFIG_HYPFS_CONFIG) += config_data.o > obj-$(CONFIG_CORE_PARKING) += core_parking.o > obj-y += cpu.o > obj-$(CONFIG_DEBUG_TRACE) += debugtrace.o > +obj-$(CONFIG_DEVICE_INIT) += device.o obj-$(CONFIG_HAS_DEVICE_TREE) += device.o obj-$(filter-out $(CONFIG_X86),$(CONFIG_ACPI)) += device.o ? (Eventually we could then simplify this to just obj-$(CONFIG_ACPI), to allow DT on x86, making sure the ACPI part of the file builds for x86 but does nothing there.) Jan
