Anthony PERARD writes ("[PATCH v3 31/31] libxl: QEMU startup sync based on
QMP"):
> This is only activated when dm_restrict=1, as explained in the previous
> patch "libxl_dm: Pre-open QMP socket for QEMU"
...
> @@ -1603,11 +1603,16 @@ struct libxl__spawn_state {
> libxl__spawn_confirm_cb *confirm_cb;
> libxl__spawn_detached_cb *detached_cb;
>
> + /* If qmp_domid != INVALID_DOMID, then libxl__spawn_spawn will also use
> QMP
> + * to find out when the process is started */
> + uint32_t qmp_domid;
> +
I think this is a layering violation. libxl__spawn_* is a thing for
double forking and shouldn't know about qmp. I think you need to
handle this the way the xenstore readiness is handled.
Thanks,
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
