Anthony PERARD writes ("[PATCH v3 13/31] libxl_qmp: Separate QMP message
generation from qmp_send_prepare"):
> This new function qmp_prepare_qmp_cmd() can be reuse later when
> introducing a different way to communicate with a QMP server,
> libxl__ev_qmp.
>
> Also, add the QMP end of command '\r\n' into the generated string.
Would it be terribly inconvenient if this function
> +static char *qmp_prepare_qmp_cmd(libxl__gc *gc,
> + const char *cmd,
> + const libxl__json_object *args,
> + int id,
> + size_t *len_r)
...
> + ret = libxl__malloc(NOGC, len + 3);
actually used its incoming gc ? Perhaps it needs a 2nd gc argument ?
I think for future we should be using some appropriate ao gc, or
something, for these buffers. But, anyway, that is a future
improvement, and not a blocker for this patch.
So:
Acked-by: Ian Jackson <ian.jack...@eu.citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
