On 05.09.2024 14:21, Andrew Cooper wrote: > On 05/09/2024 12:36 pm, Jan Beulich wrote: >> These being controlled by XCR0, enabling support is relatively >> straightforward. Note however that there won't be any use of them until >> their dependent ISA extension CPUID flags are exposed, not the least due >> to recalculate_xstate() handling the dependencies in kind of a reverse >> manner. >> >> Signed-off-by: Jan Beulich <jbeul...@suse.com> > > Reviewed-by: Andrew Cooper <andrew.coop...@citrix.com>
Thanks. > It might be worth noting that xstate_check_sizes() already probes AMX_TILE? I've added a sentence. > For future xstates, I'd expect matching updates to recalculate_xstate() > and xstate_check_sizes(). Indeed that's how the somewhat similar APX patch has it that's yet to be posted. >> --- >> Intended to replace part of (and go beyond) "x86/cpufeatures: Add new >> cpuid features in SPR to featureset". > > Matt is OoO for a while. Given this interaction was the only concern, > I'll probably rebase the feature patch and commit it. Fine with me. Jan
