Hi Victor, On 29/08/2024 06:09, victorm.l...@amd.com wrote: > > > From: Victor Lira <victorm.l...@amd.com> > > Fix flaw in qemu-*.sh tests that producess a false success. The following > lines produces success despite the "expect" script producing nonzero exit > status. > > set +e > ... > ./automation/scripts/qemu-key.exp | sed 's/\r\+$//' > (end of file) > > The "set +e" is sometimes needed for cleanup such as powering off hardware > after running a test. > > Fixes the CI failure introduced by 95764a0817. You may want to use "Fixes" tag. See docs/process/sending-patches.pandoc.
> > Update xilinx-smoke tests to use the "expect" utility for early exit from > tests. Generalize the variable names in the script "qemu-key.exp" to be > used by both QEMU and hardware tests. Add a missing "-continue_timer" flag > for the expect script to properly time out. Add "expect" to xilinx > dockerfile. This commit tries to do 2 thins at once: - fix "set +e" issue - make xilinx tests use expect These should be 2 separate patches. The first patch should only remove "set +e" from qemu patches. There is no need for fifo in qemu tests. You should use that only in xilinx tests where we cannot remove "set +e". ~Michal
