Hello Daniel, On Mon, Aug 26, 2024 at 6:16 PM Daniel P. Smith <dpsm...@apertussolutions.com> wrote: > > On 8/19/24 11:39, Jan Beulich wrote: > > On 19.08.2024 17:34, Milan Đokić wrote: > >> On Mon, Jul 29, 2024 at 1:42 PM Jan Beulich <jbeul...@suse.com> wrote: > >>> On 23.07.2024 20:22, Milan Djokic wrote: > >>>> From: Nikola Jelic <nikola.je...@rt-rk.com> > >>>> > >>>> Added PE/COFF generic image header which shall be used for EFI > >>>> application format for x86/risc-v. x86 and risc-v source shall be > >>>> adjusted > >>>> to use this header in following commits. pe.h header is taken over from > >>>> linux kernel with minor changes in terms of formatting and structure > >>>> member comments. > >>>> Also, COFF relocation and win cert structures are ommited, since these > >>>> are not relevant for Xen. > >>>> > >>>> Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > >>>> 36e4fc57fc16 > >>>> > >>>> Signed-off-by: Nikola Jelic <nikola.je...@rt-rk.com> > >>>> Signed-off-by: Milan Djokic <milan.djo...@rt-rk.com> > >>> > >>> This looks okay to me now, but I can't ack it (or more precisely my ack > >>> wouldn't mean anything). There are a few style issues in comments, but > >>> leaving them as they are in Linux may be intentional. Just one question, > >>> more to other maintainers than to you: > >>> > >> Are we supposed to CC someone additionally for approval? > > > > No, you did Cc the right people afaics. You may want to ping the > > maintainers, > > though. > Should this not be submitted as part of a series that makes use of it? > Would doing so not also address what declarations are actually needed? > We have sent subsequent patch (after this one was committed to staging) which modifies x86 implementation to use these declarations: https://lists.xenproject.org/archives/html/xen-devel/2024-08/msg01110.html My understanding was that we need to separate patches which reuse existing open-source code from the ones which update xen source itself. Since these changes are not too big and do not relate to multiple Xen topics (only EFI), I thought that they are not applicable for patch series. Although after your comment it seems that I could be wrong :) .
BR, Milan
