Hi Ayan,
On 08/08/2024 14:09, Ayan Kumar Halder wrote:
> All the EL2 MMU specific registers are enclosed within CONFIG_MMU.
>
> Signed-off-by: Ayan Kumar Halder <ayan.kumar.hal...@amd.com>
> ---
> Changes from v1 :-
> 1. 'vttbr_el2' field is enclosed with ifdef.
> 2. No movement of code.
>
> xen/arch/arm/traps.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c
> index aac6c599f8..f51e1424cb 100644
> --- a/xen/arch/arm/traps.c
> +++ b/xen/arch/arm/traps.c
> @@ -720,8 +720,10 @@ struct reg_ctxt {
> uint32_t ifsr32_el2;
> #endif
>
> +#ifdef CONFIG_MMU
> /* Hypervisor-side state */
> uint64_t vttbr_el2;
Given that you protected the field here, why did you leave assignments in
show_registers()
and vcpu_show_registers() unguarded?
~Michal
