On 06.08.2024 11:49, oleksii.kuroc...@gmail.com wrote:
> On Mon, 2024-07-29 at 15:35 +0200, Jan Beulich wrote:
>>> + write_pte(pte, tmp);
>>> +
>>> + sfence_vma();
>>> +
>>> + printk("(XEN) fixmap is mapped\n");
>>
>> Why the (XEN) prefix? And perhaps why the printk() in the first
>> place?
> printk() is available after common code started to be buildable and can
> be used here as we have already introduced early_puts() which uses
> sbi_console_putchar(). So it doesn't matter if we use printk() or
> early_printk() here the result will be the same the call of
> sbi_console_putchar().
>
> Am I missing something?
Apparently yes, as you answered neither of my questions. To put them
differently: What value does this log message have, outside of your
own development activities? What value does the explicit (XEN) have
when printk() prepends such a prefix already anyway?
Jan
