On 23.07.2024 10:15, Alessandro Zucchelli wrote: > From: Simone Ballarin <simone.balla...@bugseng.com> > > Amend inclusion guards to address violations of > MISRA C:2012 Directive 4.10 ("Precautions shall be taken in order > to prevent the contents of a header file being included more than > once"). > > Inclusion guards must appear at the beginning of the headers > (comments are permitted anywhere) and the #if directive cannot > be used for other checks. > > Mechanical change. > > Signed-off-by: Simone Ballarin <simone.balla...@bugseng.com> > Signed-off-by: Maria Celeste Cesario <maria.celeste.cesa...@bugseng.com> > Acked-by: Julien Grall <jgr...@amazon.com> > Reviewed-by: Stefano Stabellini <sstabell...@kernel.org> > Signed-off-by: Nicola Vetrini <nicola.vetr...@bugseng.com> > Signed-off-by: Alessandro Zucchelli <alessandro.zucche...@bugseng.com>
Provided the description of the scheme itself goes in first: Acked-by: Jan Beulich <jbeul...@suse.com> > --- > Changes in v5: > - edit inclusion guards, according to the feedback received Given how exactly the guards look like is the main aspect here, I question the retaining of earlier R-b with changes like what is said here. Jan