On 22.07.2024 13:27, Tamas K Lengyel wrote: > --- /dev/null > +++ b/LICENSES/Apache-2.0 > @@ -0,0 +1,202 @@ > + > + Apache License > + Version 2.0, January 2004 > + http://www.apache.org/licenses/
Better https:// (also near the end) nowadays? Other files in this directory also have at least one Valid-License-Identifier: line and at least one SPDX-URL: one. Depending on what would be put there, I'd then wonder whether ... > --- /dev/null > +++ b/tools/fuzz/oss-fuzz/build.sh > @@ -0,0 +1,11 @@ > +#!/bin/bash -eu > +# Copyright 2024 Google LLC > +# SPDX-License-Identifier: Apache-2.0 ... there wouldn't want to be an "-only" tag here. Yet I'm entirely uncertain with this, as CC-BY-4.0 also has no such tag. I guess I should offer making respective adjustments while committing. I'll wait with an ack though to give Alejandro some time to confirm that you addressed his bash related comment. Jan > +# This script is intended to be run only from the oss-fuzz docker framework > +# See > https://google.github.io/oss-fuzz/getting-started/new-project-guide/#buildsh > +cd xen > +./configure --disable-stubdom --disable-pvshim --disable-docs --disable-xen > --with-system-qemu > +make clang=y -C tools/include > +make clang=y -C tools/fuzz/x86_instruction_emulator libfuzzer-harness > +cp tools/fuzz/x86_instruction_emulator/libfuzzer-harness > $OUT/x86_instruction_emulator
