On 10.07.2024 10:28, Sergiy Kibrik wrote: > Separate ACPI driver from generic initialization cpufreq code. > This way acpi-cpufreq can become optional in the future and be disabled > from non-Intel builds. > > no changes to code were introduced, except: > acpi_cpufreq_register() helper added > clean up a list of included headers > license transformed into an SPDX line > > Signed-off-by: Sergiy Kibrik <sergiy_kib...@epam.com>
Reviewed-by: Jan Beulich <jbeul...@suse.com> with perhaps two tiny further adjustments, which I'd be happy to do while committing: > --- /dev/null > +++ b/xen/arch/x86/acpi/cpufreq/acpi.c > @@ -0,0 +1,518 @@ > +/* SPDX-License-Identifier: GPL-2.0-or-later */ > +/* > + * cpufreq.c - ACPI Processor P-States Driver ($Revision: 1.4 $) > + * > + * Copyright (C) 2001, 2002 Andy Grover <andrew.gro...@intel.com> > + * Copyright (C) 2001, 2002 Paul Diefenbaugh <paul.s.diefenba...@intel.com> > + * Copyright (C) 2002 - 2004 Dominik Brodowski <li...@brodo.de> > + * Copyright (C) 2006 Denis Sadykov <denis.m.sady...@intel.com> > + * > + * Feb 2008 - Liu Jinsong <jinsong....@intel.com> > + * porting acpi-cpufreq.c from Linux 2.6.23 to Xen hypervisor > + */ > + > +#include <xen/types.h> > +#include <xen/errno.h> > +#include <xen/delay.h> > +#include <xen/param.h> Would be nice if in the new file xen/ #include-s were sorted. > +#include <acpi/acpi.h> > +#include <acpi/cpufreq/cpufreq.h> > + > + No double blank lines please. Jan
