From: Christoph Hellwig <h...@lst.de> Sent: Monday, July 8, 2024 11:26 PM > > Hi Michael, > > I've applied this, but I've made a few changes before that directly as > we're getting close to the end of the merge window. > > Most of it is very slight formatting tweaks, but I've also kept the > dma_uses_io_tlb field under ifdef CONFIG_SWIOTLB_DYNAMIC as I > don't want to touch the device structure layout. > > Let me me know if this is ok for you. If I can get reviews today > or tomorrow I'd also love to add them, but given that all this has > been extensively discussed I went ahead with applying it. > > Thanks for all your work!
Your tweaks look fine to me. Evidently I misunderstood your preference in our previous exchange about #ifdef vs. IS_ENABLED() in swiotlb_find_pool(), and the effect on dma_uses_io_tlb. Reverting to the #ifdef version and leaving dma_uses_io_tlb unchanged is my preference as well. The #ifdef version also had #ifdef CONFIG_SWIOTLB_DYNAMIC around the declaration of __swiotlb_find_pool(), but that doesn't really matter either way. Michael
