On 2024-07-01 10:27, Jan Beulich wrote:
On 27.06.2024 02:57, Stefano Stabellini wrote:
On Wed, 26 Jun 2024, Nicola Vetrini wrote:
From: Alessandro Zucchelli <alessandro.zucche...@bugseng.com>
This addresses violations of MISRA C:2012 Rule 5.3 which states as
following: An identifier declared in an inner scope shall not hide an
identifier declared in an outer scope.
In this case the gloabl variable being shadowed is the global static
struct
mctctl in this file, therefore the local variables are renamed to
avoid this.
"global" and "static" contradict one another; I think you mean "file
scope".
Yes.
While there (nit) also s/gloabl/global/ or perhaps even s/gloabl// to
deal
with the conflict with "static" also there (without writing "file
scope"
twice).
No functional change.
Signed-off-by: Alessandro Zucchelli
<alessandro.zucche...@bugseng.com>
Signed-off-by: Nicola Vetrini <nicola.vetr...@bugseng.com>
Nice one!
Reviewed-by: Stefano Stabellini <sstabell...@kernel.org>
With the adjustment:
Acked-by: Jan Beulich <jbeul...@suse.com>
Jan
--
Nicola Vetrini, BSc
Software Engineer, BUGSENG srl (https://bugseng.com)
