Hi Michal,
> On 26 Jun 2024, at 09:04, Michal Orzel <michal.or...@amd.com> wrote:
>
> Memory node probing is done as part of early_scan_node() that is called
> for each node with depth >= 1 (root node is at depth 0). According to
> Devicetree Specification v0.4, chapter 3.4, /memory node can only exists
> as a top level node. However, Xen incorrectly considers all the nodes with
> unit node name "memory" as RAM. This buggy behavior can result in a
> failure if there are other nodes in the device tree (at depth >= 2) with
> "memory" as unit node name. An example can be a "memory@xxx" node under
> /reserved-memory. Fix it by introducing device_tree_is_memory_node() to
> perform all the required checks to assess if a node is a proper /memory
> node.
>
> Fixes: 3e99c95ba1c8 ("arm, device tree: parse the DTB for RAM location and
> size")
> Signed-off-by: Michal Orzel <michal.or...@amd.com>
> ---
> 4.19: This patch is fixing a possible early boot Xen failure (before main
> console is initialized). In my case it results in a warning "Shattering
> superpage is not supported" and panic "Unable to setup the directmap
> mappings".
>
> If this is too late for this patch to go in, we can backport it after the tree
> re-opens.
> ---
It looks ok to me,
Reviewed-by: Luca Fancellu <luca.fance...@arm.com>
I’ve also tested on FVP, I’ll put it through our CI and I’ll let you know.
Tested-by: Luca Fancellu <luca.fance...@arm.com>
