On 25.06.2024 02:47, Stefano Stabellini wrote: > I would like to ask for a release-ack as the patch series makes very few > changes outside of the static analysis configuration. The few changes to > the Xen code are very limited, straightforward and makes the code > better, see patch #3 and #5.
While continuing to touch automation/ may be okay, I really think time has passed for further Misra changes in 4.19, unless they're fixing actual bugs of course. Just my personal view though ... Jan > On Mon, 17 Jun 2024, Nicola Vetrini wrote: >> Hi all, >> >> this series addresses several violations of Rule 20.7, as well as a >> small fix to the ECLAIR integration scripts that do not influence >> the current behaviour, but were mistakenly part of the upstream >> configuration. >> >> Note that by applying this series the rule has a few leftover violations. >> Most of those are in x86 code in xen/arch/x86/include/asm/msi.h . >> I did send a patch [1] to deal with those, limited only to addressing the >> MISRA >> violations, but in the end it was dropped in favour of a more general >> cleanup of >> the file upon agreement, so this is why those changes are not included here. >> >> [1] >> https://lore.kernel.org/xen-devel/2f2c865f20d0296e623f1d65bed25c083f5dd497.1711700095.git.nicola.vetr...@bugseng.com/ >> >> Changes in v2: >> - refactor patch 4 to deviate the pattern, instead of fixing the violations >> - The series has been resent because I forgot to properly Cc the mailing list >> >> Nicola Vetrini (6): >> automation/eclair: address violations of MISRA C Rule 20.7 >> xen/self-tests: address violations of MISRA rule 20.7 >> xen/guest_access: address violations of MISRA rule 20.7 >> automation/eclair_analysis: address violations of MISRA C Rule 20.7 >> x86/irq: address violations of MISRA C Rule 20.7 >> automation/eclair_analysis: clean ECLAIR configuration scripts >> >> automation/eclair_analysis/ECLAIR/analyze.sh | 3 +-- >> automation/eclair_analysis/ECLAIR/deviations.ecl | 14 ++++++++++++-- >> docs/misra/deviations.rst | 3 ++- >> xen/include/xen/guest_access.h | 4 ++-- >> xen/include/xen/irq.h | 2 +- >> xen/include/xen/self-tests.h | 8 ++++---- >> 6 files changed, 22 insertions(+), 12 deletions(-) >> >> -- >> 2.34.1 >>
