On 24.06.2024 23:23, Tamas K Lengyel wrote: > On Mon, Jun 24, 2024 at 11:55 AM Jan Beulich <jbeul...@suse.com> wrote: >> >> On 21.06.2024 21:14, Tamas K Lengyel wrote: >>> @@ -58,6 +58,9 @@ afl-harness: afl-harness.o $(OBJS) cpuid.o wrappers.o >>> afl-harness-cov: afl-harness-cov.o $(patsubst %.o,%-cov.o,$(OBJS)) cpuid.o >>> wrappers.o >>> $(CC) $(CFLAGS) $(GCOV_FLAGS) $(addprefix >>> -Wl$(comma)--wrap=,$(WRAPPED)) $^ -o $@ >>> >>> +libfuzzer-harness: $(OBJS) cpuid.o >>> + $(CC) $(CFLAGS) $(LIB_FUZZING_ENGINE) -fsanitize=fuzzer $^ -o $@ >> >> What is LIB_FUZZING_ENGINE? I don't think we have any use of that in the >> tree anywhere. > > It's used by oss-fuzz, otherwise it's not doing anything. > >> >> I'm further surprised you get away here without wrappers.o. > > Wrappers.o was actually breaking the build for oss-fuzz at the linking > stage. It works just fine without it.
I'm worried here, to be honest. The wrappers serve a pretty important role, and I'm having a hard time seeing why they shouldn't be needed here when they're needed both for the test and afl harnesses. Could you add some more detail on the build issues you encountered? Jan
