On 20/06/2024 4:34 pm, Jan Beulich wrote: > When the left shift amount is up to 31, the shifted quantity wants to be > of unsigned int (or wider) type. > > While there also adjust types: get doesn't alter the array and returns a > boolean, while both don't really accept negative "nr". Drop a stray > blank each as well. > > Signed-off-by: Jan Beulich <jbeul...@suse.com>
Reviewed-by: Andrew Cooper <andrew.coop...@citrix.com> +1 for 4.19. > --- > Really I wonder why these exist at all; they're effectively test_bit() > and __set_bit() in hypervisor terms, and iirc something like that exists > in the tool stack as well. The toolstack has tools/libs/ctrl/xc_bitops.h but they're not API compatible with Xen. They're long-granular rather than int-granular, have swapped arguments, and are non-LOCKed. ~Andrew
