On 10/06/2024 2:32 pm, Marek Marczykowski-Górecki wrote: > This tests if QEMU works in PVH dom0. QEMU in dom0 requires enabling TUN > in the kernel, so do that too. > > Add it to both x86 runners, similar to the PVH domU test. > > Signed-off-by: Marek Marczykowski-Górecki <marma...@invisiblethingslab.com>
Acked-by: Andrew Cooper <andrew.coop...@citrix.com> CC Oleksii. > --- > Requires rebuilding test-artifacts/kernel/6.1.19 Ok. But on a tangent, shouldn't that move forwards somewhat? > > I'm actually not sure if there is a sense in testing HVM domU on both > runners, when PVH domU variant is already tested on both. Are there any > differences between Intel and AMD relevant for QEMU in dom0? It's not just Qemu, it's also HVMLoader, and the particulars of VT-x/SVM VMExit decode information in order to generate ioreqs. I'd firmly suggest having both. ~Andrew