On 31.05.2024 10:05, Sergiy Kibrik wrote: > 16.05.24 15:11, Jan Beulich: >> On 15.05.2024 11:24, Sergiy Kibrik wrote: >>> --- a/xen/arch/x86/hvm/emulate.c >>> +++ b/xen/arch/x86/hvm/emulate.c >>> @@ -2667,7 +2667,9 @@ static int _hvm_emulate_one(struct hvm_emulate_ctxt >>> *hvmemul_ctxt, >>> break; >>> >>> case VIO_mmio_completion: >>> +#ifdef CONFIG_VMX >>> case VIO_realmode_completion: >>> +#endif >>> BUILD_BUG_ON(sizeof(hvio->mmio_insn) < >>> sizeof(hvmemul_ctxt->insn_buf)); >>> hvio->mmio_insn_bytes = hvmemul_ctxt->insn_buf_bytes; >>> memcpy(hvio->mmio_insn, hvmemul_ctxt->insn_buf, >>> hvio->mmio_insn_bytes); >> >> This change doesn't buy us anything, does it? > > why not? Code won't compile w/o it. > Or do you mean hiding the whole VIO_realmode_completion enum under > CONFIG_VMX wasn't really useful?
That's what I meant, by implication. To me it's extra #ifdef-ary without real gain. Jan
