On 24.05.24 16:30, Jürgen Groß wrote:
On 24.05.24 15:58, Julien Grall wrote:Hi Henry,+ Juergen as the Xenstore maintainers. I'd like his opinion on the approach. The documentation of the new logic is in:https://lore.kernel.org/xen-devel/20240517032156.1490515-5-xin.wa...@amd.com/FWIW I am happy in principle with the logic (this is what we discussed on the call last week). Some comments below.I'm not against this logic, but I'm wondering why it needs to be so complicated. Can't the domU itself allocate the Xenstore page from its RAM pages, write the PFN into the Xenstore grant tab entry, and then make it public via setting HVM_PARAM_STORE_PFN? The init-dom0less application could then check HVM_PARAM_STORE_PFN being set and call XS_introduce_domain. Note that at least C-xenstored does not need the PFN of the Xenstore page, as it is just using GNTTAB_RESERVED_XENSTORE for mapping the page.
Hmm, seems as if O-xenstored is using the map_foreign_page mechanism with the PFN to map the Xenstore ring page. Maybe this should be changed to use the grant entry, too? Juergen
OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key
OpenPGP_signature.asc
Description: OpenPGP digital signature
