On Thu, May 16, 2024 at 07:58:02PM +0100, Andrew Cooper wrote: > ... in order to avoid linking against the whole of libsystemd. > > Only minimal changes to the upstream copy, to function as a drop-in > replacement for sd_notify() and as a header-only library.
Maybe add explicit link to the original source?
> Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com>
> ---
> CC: Anthony PERARD <anth...@xenproject.org>
> CC: Juergen Gross <jgr...@suse.com>
> CC: George Dunlap <george.dun...@citrix.com>
> CC: Jan Beulich <jbeul...@suse.com>
> CC: Stefano Stabellini <sstabell...@kernel.org>
> CC: Julien Grall <jul...@xen.org>
> CC: Christian Lindig <christian.lin...@citrix.com>
> CC: Edwin Török <edwin.to...@cloud.com>
>
> v2:
> * New
> ---
> tools/include/xen-sd-notify.h | 98 +++++++++++++++++++++++++++++++++++
> 1 file changed, 98 insertions(+)
> create mode 100644 tools/include/xen-sd-notify.h
>
> diff --git a/tools/include/xen-sd-notify.h b/tools/include/xen-sd-notify.h
> new file mode 100644
> index 000000000000..eda9d8b22d9e
> --- /dev/null
> +++ b/tools/include/xen-sd-notify.h
> @@ -0,0 +1,98 @@
...
> +static inline void xen_sd_closep(int *fd) {
Static inline is one of the changes vs upstream, and gitlab-ci is not
happy about it:
/builds/xen-project/patchew/xen/tools/xenstored/../../tools/include/xen-sd-notify.h:45:3:
error: cleanup argument not a function
45 | int __attribute__((cleanup(sd_closep))) fd = -1;
| ^~~
--
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
signature.asc
Description: PGP signature
