On 16.05.2024 02:38, Stefano Stabellini wrote: > On Wed, 15 May 2024, Sergiy Kibrik wrote: >> --- a/xen/arch/x86/include/asm/p2m.h >> +++ b/xen/arch/x86/include/asm/p2m.h >> @@ -581,9 +581,9 @@ static inline gfn_t mfn_to_gfn(const struct domain *d, >> mfn_t mfn) >> return _gfn(mfn_x(mfn)); >> } >> >> -#ifdef CONFIG_HVM >> #define AP2MGET_prepopulate true >> #define AP2MGET_query false >> +#ifdef CONFIG_ALTP2M > > Is it necessary? Can't we just replace CONFIG_HVM with CONFIG_ALTP2M on > the same line
No, because of where those constants are used. Sergiy, you want to move the new #ifdef down by a line though, such that the #define-s are separated from it by the blank line that presently (with your change applied) follows the #ifdef line. Jan