On Thu, Apr 11, 2024 at 03:28:20PM +0300, Manos Pitsidianakis wrote: > Various timeout values that depend on the device model should also > respect the device model start timeout setting. This commit adds the > __libxl_device_model_start_timeout() value to those time outs without > changing their default values.
I don't like much this patch. It multiplies all qmp_cmd timeouts by 7. First, could you make two separate patches for the changes? One to change LIBXL_QMP_CMD_TIMEOUT, and one to change LIBXL_STUBDOM_START_TIMEOUT. Second, when the environment variable is unset, the timeout should stay at 10 for the qmp_cmd one. If for some reason that chosen value is to low, we could always have a separate patch to adjust the value. Cheers, -- Anthony PERARD
