On 11.04.2024 01:47, Stefano Stabellini wrote: > The goal is to use only fixed-size integers in public headers, such as > uint32_t and uint64_t. > > However, there are cases where the ABI changes depending on the > architecture. In those cases, adding #ifdefs might be the clearest > solution but it is also cumbersome. We already define a xen_ulong_t type > which is widely used in public headers and it is defined differently by > architecture. > > Instead of unsigned long, use xen_ulong_t in public headers: > - it makes it clearer that size might change by arch > - it gets us closer to the goal of no unfixed-size integers in public > headers > > Note that unsigned long and xen_ulong_t are the same thing on x86 (both > 32-bit and 64-bit) but they differ on all other arches. However, all > the interfaces with xen_ulong_t or unsigned long are x86-only interfaces > today. Thus, this patch doesn't introduce any ABI or semantic changes.
And it is presumably because of this that the conversion wasn't done for these when it was done elsewhere for the Arm port, many years ago. > Signed-off-by: Stefano Stabellini <stefano.stabell...@amd.com> Acked-by: Jan Beulich <jbeul...@suse.com> Jan
