On 4/11/24 15:24, Andrew Cooper wrote:
On 11/04/2024 4:25 pm, Daniel P. Smith wrote:
diff --git a/xen/common/gzip/gunzip.c b/xen/common/gzip/gunzip.c
index 1bcb007395ba..9b4891731b8b 100644
--- a/xen/common/gzip/gunzip.c
+++ b/xen/common/gzip/gunzip.c
@@ -102,12 +109,13 @@ __init int gzip_check(char *image, unsigned long
image_len)
__init int perform_gunzip(char *output, char *image, unsigned long image_len)
{
+ struct gzip_data gd;
int rc;
By the end of this series,
Reading symbols from xen-syms...
(gdb) p sizeof(struct gzip_data)
$1 = 2120
x86 has an 8k stack and this takes 1/4 of it. Other bits of state are
dynamically allocated, even in inflate.c, so I'd highly recommend doing
the same for this.
I take it you are mainly talking about crc_32_tab? Yes, I can switch
that to being dynamically allocated.
Also, could I nitpick the name and request:
struct gzip_state *s;
I have no attachment to names, so yes, I can switch the name.
v/r,
dps
